Skip to content

Conversation

henrikmidtiby
Copy link
Contributor

I have identified some tests that I would like to fix in experimental. The tests can be evaluatated by this command.

pytest tests/module/mobject/types/vectorized_mobject/test_stroke.py

Now I have tried to make the tests pass, by changes like

  • changing base class from VMobject to OpenGLVMobject
  • fill_opacity -> get_fill_opacity()

Is this a suitable approach?

Further Information and Comments

To make the commit I had to ignore all mypy errors. Is that the preferred approach?

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

tests/module/mobject/geometry/test_unit_geometry.py::test_BackgroundRectangle
@henrikmidtiby henrikmidtiby deleted the ExperimentalSurroundingRectangleAndStreamLines branch July 29, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant